Fix discord media in matrix #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for media coming from discord without needing to store them on the server.
It uses our fork of the discord_cdn project (https://github.com/aosus/Discord_CDN), which has some patches to make it work well in docker.
It will redirect any normal CDN links to signed ones fetched using a user token.
This workaround doesn't proxy the redirect (couldn't figure it out), which means this won't work with homeservers without support for MSC3860, but since synapse supports it, that pretty much covers 95% of matrix server out there.
fix aosus/infrastructure-meta#5