Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Commit

Permalink
[SPARK-20613] Remove excess quotes in Windows executable
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?

Quotes are already added to the RUNNER variable on line 54. There is no need to put quotes on line 67. If you do, you will get an error when launching Spark.

'""C:\Program' is not recognized as an internal or external command, operable program or batch file.

## How was this patch tested?

Tested manually on Windows 10.

Author: Jarrett Meyer <jarrettmeyer@gmail.com>

Closes apache#17861 from jarrettmeyer/fix-windows-cmd.

(cherry picked from commit b9ad2d1)
Signed-off-by: Felix Cheung <felixcheung@apache.org>
  • Loading branch information
jarrettmeyer authored and Felix Cheung committed May 5, 2017
1 parent dbb54a7 commit 1fa3c86
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bin/spark-class2.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ if not "x%SPARK_PREPEND_CLASSES%"=="x" (
rem Figure out where java is.
set RUNNER=java
if not "x%JAVA_HOME%"=="x" (
set RUNNER="%JAVA_HOME%\bin\java"
set RUNNER=%JAVA_HOME%\bin\java
) else (
where /q "%RUNNER%"
if ERRORLEVEL 1 (
Expand Down

0 comments on commit 1fa3c86

Please sign in to comment.