Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): fix tick labels and tooltip #1447

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Nov 1, 2021

🐛 Bug Fix

Fixes multiple issues on the Mixed Timeseries chart:

  • Tooltip x-axis value shows 0NaN when rich tooltip is disabled and the value is a decimal.
  • On the case of a mixed line+bar chart, the bars below the line won't show in the tooltip.
  • Remove bogus min and max x-axis values (these have been deprecated from the main Timeseries chart some time ago).

AFTER

Tooltip correctly shows the x-axis value when the y-value is a decimal:
image

The erroneous min and max x-axis values are removed, and hovering on a bar underneath a line works as intended:
https://user-images.githubusercontent.com/33317356/139655494-8ab0257a-2ece-4821-a41e-727437cd8490.mp4

BEFORE

Tooltip shows 0NaN when the metric value is a decimal value:
image

The x-axis shows incorrect min and max values, and hovering on a bar underneath a line doesn't display the bar value correctly:
https://user-images.githubusercontent.com/33317356/139655424-20628415-b6a2-46a7-81e7-fb310e894e19.mp4

@villebro villebro requested a review from a team as a code owner November 1, 2021 10:07
@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2d1W5aV4E93vwe1u7yTJQJuahH2v
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-mixed-bugs-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1447 (5406bce) into master (6b8cda4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   30.43%   30.43%   -0.01%     
==========================================
  Files         497      497              
  Lines       10012    10013       +1     
  Branches     1691     1692       +1     
==========================================
  Hits         3047     3047              
- Misses       6719     6720       +1     
  Partials      246      246              
Impacted Files Coverage Δ
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <0.00%> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 80.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 53.75% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 43.36% <0.00%> (-0.39%) ⬇️
...ugins/plugin-chart-echarts/src/Timeseries/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8cda4...5406bce. Read the comment docs.

@stephenLYZ
Copy link
Contributor

Thanks for the improvement! LGTM and just left a comment.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 744d732 into apache-superset:master Nov 1, 2021
@villebro villebro deleted the villebro/mixed-bugs branch November 1, 2021 12:22
@kgabryje kgabryje mentioned this pull request Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants