Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): fix opacity on area chart #1464

Merged

Conversation

villebro
Copy link
Contributor

🐛 Bug Fix

#1447 introduced a regression to area charts which broke both area and confidence bands. The reason for the original change was to remove area if it's not needed (a 0 opacity made it impossible to hover series underneath the series).

AFTER

image

BEFORE

image

@villebro villebro requested a review from a team as a code owner November 10, 2021 16:00
@vercel
Copy link

vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/DYdKfA1QH9TpQTVSzRWx2oiPPn88
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-fix-are-1b95f4-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1464 (ff5262f) into master (ba2703f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   30.91%   30.91%           
=======================================
  Files         503      503           
  Lines       10215    10214    -1     
  Branches     1761     1760    -1     
=======================================
  Hits         3158     3158           
+ Misses       6805     6804    -1     
  Partials      252      252           
Impacted Files Coverage Δ
...lugin-chart-echarts/src/Timeseries/transformers.ts 42.24% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2703f...ff5262f. Read the comment docs.

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants