-
Notifications
You must be signed in to change notification settings - Fork 272
feat: allow toggling of table viz's bar chart backgrounds #352
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/superset/superset-ui/ear00opxw |
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
===========================================
- Coverage 91.67% 51.76% -39.92%
===========================================
Files 118 122 +4
Lines 1489 2639 +1150
Branches 388 391 +3
===========================================
+ Hits 1365 1366 +1
- Misses 95 1244 +1149
Partials 29 29
Continue to review full report at Codecov.
|
@krist this one is minor, but would love to know how you prefer to approach these double-PRs as a coordinated effort. We can discuss on Slack if it's easier :D |
plugins/table/src/ReactDataTable.tsx
Outdated
return ( | ||
<td | ||
key={key} | ||
// only set innerHTML for actual html content, this saves time | ||
dangerouslySetInnerHTML={isHtml ? { __html: text } : undefined} | ||
data-sort={val} | ||
className={keyIsMetric ? 'text-right' : ''} | ||
className={showCellBar ? 'text-right' : ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably makes sense to always align metrics to the right even if we don't need to show the bar chart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's fine... it looks more wrong than right to me to have them right-aligned in many cases, but that all depends on the number formatting. I guess there's no need to squeeze that extra change, as it wasn't part of the original issue. I'll change it back.
Thanks for the review, @ktmud :) If you don't mind reviewing/approving the superset PR, I'll merge both, unless you see any deployment problems in doing so. |
published as |
Bumps [storybook-addon-jsx](https://github.com/storybookjs/addon-jsx) from 7.1.2 to 7.1.14. - [Release notes](https://github.com/storybookjs/addon-jsx/releases) - [Changelog](https://github.com/storybookjs/addon-jsx/blob/master/CHANGELOG.md) - [Commits](storybookjs/addon-jsx@v7.1.2...v7.1.14) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
🏆 Enhancements
Fixes, in coordination with this parallel PR, Superset issue #9499