Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine WALs used by root tablet during GC #1310

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

keith-turner
Copy link
Contributor

No description provided.

@keith-turner
Copy link
Contributor Author

I noticed this while working on #936. It seems the GC of walogs does not look at what walogs the root tablet may be using. In many cases if the root tablet has walogs it likely that the metadata table can not be read and GC would block. However this is not always the case as the location of the metadata table may be cached and metadata tablets may still be online.

@keith-turner keith-turner merged commit 54b2c32 into apache:1.9 Aug 14, 2019
@ctubbsii
Copy link
Member

Did #936 address this in the 2.1 branch already?

@keith-turner
Copy link
Contributor Author

Did #936 address this in the 2.1 branch already?

No it did not. That change was concerning tablet files. This changes is related to WALs. In the GC files and WALs are two separate pieces of code.

@ctubbsii
Copy link
Member

Did #936 address this in the 2.1 branch already?

No it did not. That change was concerning tablet files. This changes is related to WALs. In the GC files and WALs are two separate pieces of code.

It sounds like this got fixed in 2.1.0 by means of merging this PR, and not by the other issue. I'll mark this issue as "Done" for 2.1.0 accordingly.

@ctubbsii ctubbsii added this to the 1.10.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants