New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annoying pop-up in Monitor #3057
Comments
I looked at this in detail and there are several issues here of why this happens compared to the Manager page.
So based on this I think we need to decide what we want to do. One thing that should happen either way is status should always be checked on refreshes of the tables. Besides that we probably need to do one or more of the following to fix this:
Number 3 seems like the best solution to me. Just figure out a way to handle the 500 error more gracefully until the server updates the cached status to show it's down. (And of course as I said make sure the refreshes check status first). @dlmarion and @ctubbsii thoughts? Also, @DomGarguilo - Can you look at this too and see what you think about the best way to handle the issue? I saw that you worked a lot recently on the monitor including the status stuff for the manager page so you may have a better idea on how to fix it or know of something I'm not aware of as my JavaScript is pretty rusty. I'm wondering if there is something simple in the data tables to just better handle the failed Ajax call but I didn't get a chance to look into it yet. If you wanted to take a shot at fixing it feel free too otherwise I can get back to it probably Friday or next weekend. |
Sure thing 👍 ill take a look when I get a chance. Probably this coming week. |
Same. I would implement the easiest solution to stop the pop-ups, whatever that might be. |
Sounds good, I will let @DomGarguilo take a look this week and see what he thinks and I figure we can work together on a solution here. |
I found this excerpt on the datatables website:
Which is a possibility and might be the easiest "fix" for this. |
Yeah, the simplest thing I think is just handling the error and not showing the pop up. I figured datatables had a way to do it but I've never used the library (hence deferring to you to see if you knew). I can give this a shot later today/tomorrow and create a PR if it works. |
So I had some time to try this out and it works well. The errors just gets pushed to the console instead of creating alerts. @cshannon I can go ahead and put up a PR for this since I have a branch with these changes anyways. One thing that I thought of, that I'm not sure how we want to handle, is if the page is refreshed, the banner indicating "Compaction Coordinator Not Running" shows up. But it doesn't appear that this will ever happen automatically via auto-refresh and will only show up on a full page reload. An alternative to moving the datatables errors to the console could be to just refresh the page (via |
I think it makes sense to go ahead and make the easy/quick change to get rid of the annoying pop up as that is a big improvement. Then you can create a follow on issue for the reload/refresh and handling of the banner if we want to do something more. |
Definitely don't do the |
Yea that makes sense. The logic to show the mentioned banner is in the freemarker code and I'm not exact sure how that works but from what it seems, the page needs to be refreshed in order for that if statement that shows/hides the banner to be reached again. We could work out a way for that logic to be moved into the javascript so that it can be updated as part of the pages |
During testing of 2.1.0 RC4 I shut down the compaction coordinator. I had the monitor open and was on the
/ec
page to look at the external compaction information. It appears that when the ajax calls to refresh the tables failed, a pop-up would appear that said:DataTables warning: table id=<tableName> - Ajax error. For more information about this error, please see http://datatables.net/tn/7
Is there a way to suppress this and do something different? When the
manager
is down, there is just a message on the main page saying it's down - no popup.The text was updated successfully, but these errors were encountered: