Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If CompactionCoordinator dies, external compactions monitor page becomes stuck #3096

Closed
DomGarguilo opened this issue Nov 30, 2022 · 2 comments · Fixed by #3104 or #3127
Closed

If CompactionCoordinator dies, external compactions monitor page becomes stuck #3096

DomGarguilo opened this issue Nov 30, 2022 · 2 comments · Fixed by #3104 or #3127
Assignees
Labels
bug This issue has been verified to be a bug.
Projects

Comments

@DomGarguilo
Copy link
Member

DomGarguilo commented Nov 30, 2022

One thing that I thought of, that I'm not sure how we want to handle, is if the page is refreshed, the banner indicating "Compaction Coordinator Not Running" shows up. But it doesn't appear that this will ever happen automatically via auto-refresh and will only show up on a full page reload.

Originally posted by @DomGarguilo in #3057 (comment)

Another bug that might be more relevant but is caused by the same thing is when the CompactionCoordinator dies, the tables that track it and the other external compaction tables will stay on screen without any change in data. This happens because the source that the tables pull from results in an error being thrown which blocks the datatables code and keeps them as-is.

I think to fix these issues we need to move the following functionality, which checks if the CompactionCoordinator is running into the javascript code so we can handle this case and avoid having to manually refresh the page:

@DomGarguilo DomGarguilo added the bug This issue has been verified to be a bug. label Nov 30, 2022
@ctubbsii ctubbsii added this to To do in 2.1.1 via automation Nov 30, 2022
@DomGarguilo DomGarguilo self-assigned this Dec 2, 2022
2.1.1 automation moved this from To do to Done Dec 12, 2022
@ctubbsii
Copy link
Member

@DomGarguilo This ticket was marked to be fixed for 2.1.1, because the bug was observed there. However, the PR which fixes this was merged to the main branch to be fixed in 3.0.0. Was it not possible to fix this in 2.1.1? Or are you intending to backport the fix to the 2.1 maintenance branch?

@ctubbsii ctubbsii reopened this Dec 14, 2022
2.1.1 automation moved this from Done to In progress Dec 14, 2022
@DomGarguilo
Copy link
Member Author

@DomGarguilo This ticket was marked to be fixed for 2.1.1, because the bug was observed there. However, the PR which fixes this was merged to the main branch to be fixed in 3.0.0. Was it not possible to fix this in 2.1.1? Or are you intending to backport the fix to the 2.1 maintenance branch?

I can backport it to 2.1 too. I'll work on another PR against the 2.1 branch.

@asfgit asfgit closed this as completed in 2c035c0 Dec 14, 2022
2.1.1 automation moved this from In progress to Done Dec 14, 2022
@ctubbsii ctubbsii linked a pull request Dec 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue has been verified to be a bug.
Projects
No open projects
2.1.1
Done
2 participants