Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAL Recovery directories not being removed #432

Closed
keith-turner opened this issue Apr 18, 2018 · 3 comments
Closed

WAL Recovery directories not being removed #432

keith-turner opened this issue Apr 18, 2018 · 3 comments
Labels
blocker This issue blocks any release version labeled on it. bug This issue has been verified to be a bug.
Projects
1.9.1 2.0.0

Comments

@keith-turner
Copy link
Contributor

While running test for 1.9.0, I noticed some files in /accumulo/recovery that were a few days old. I investigated this and could not find any code in the garbage collector that actually deletes WALs in the recovery directory. There is code in 1.7 to delete recovered WALs, so I suspect this problem was introduced in 1.8.0 with the change in how WALs are tracked.

I also found the property master.recovery.max.age has not been used by Accumulo internals since 1.4
@keith-turner keith-turner added v2.0.0 blocker This issue blocks any release version labeled on it. bug This issue has been verified to be a bug. labels Apr 18, 2018
@ctubbsii
Copy link
Member

@keith-turner Looks like @joshelser found this first on https://issues.apache.org/jira/browse/ACCUMULO-4851 😺

@keith-turner
Copy link
Contributor Author

@ctubbsii ACCUMULO-4851 is a different issue.

@ctubbsii
Copy link
Member

Okay. My mistake.

keith-turner added a commit to keith-turner/accumulo that referenced this issue Apr 26, 2018
@keith-turner
fixes apache#432 Made GC clean up recovery logs
68ea2df
@keith-turner keith-turner mentioned this issue Apr 27, 2018
Closed
@ctubbsii ctubbsii added this to To do in 1.9.0 via automation Jun 14, 2019
@ctubbsii ctubbsii moved this from To do to Done in 1.9.0 Jun 14, 2019
@ctubbsii ctubbsii added this to Done in 1.9.1 Jun 14, 2019
@ctubbsii ctubbsii added this to Done in 2.0.0 Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker This issue blocks any release version labeled on it. bug This issue has been verified to be a bug.
Projects
No open projects
1.9.1
  
Done
2.0.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keith-turner @ctubbsii