Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a SteadyTime type in the manager #4482

Closed
keith-turner opened this issue Apr 20, 2024 · 2 comments · Fixed by #4494
Closed

Create a SteadyTime type in the manager #4482

keith-turner opened this issue Apr 20, 2024 · 2 comments · Fixed by #4494
Assignees
@cshannon
Projects
3.1.0

Comments

@keith-turner
Copy link
Contributor

keith-turner commented Apr 20, 2024 •
edited

Manager.getSteadyTime() returns a long. Replacing the long with a specialized SteadyTime type would make any use of the type in the code more apparent and correct. May also be nice to have methods for serializing and deserializing this type in a consistent way on the method as this type is intended to be serialized.
@keith-turner
Copy link
Contributor Author

keith-turner commented Apr 20, 2024 •
edited

This issue supports the possible use of steady time more in the manager code as outlined in #4481 and this comment

@cshannon cshannon self-assigned this Apr 26, 2024
@cshannon
Copy link
Contributor

cshannon commented Apr 26, 2024 •
edited

I'm starting work on this now, this seems like it might be something we could do in main.

cshannon added a commit to cshannon/accumulo that referenced this issue Apr 26, 2024
@cshannon
Create a SteadyTime type in the Manager
5ed2eff 
This replaces Manager.getSteadyTime() long value with a concrete type to
make it more apparent what time is being used. The serialization
and deserialization logic have been encapsulated as methods to make the
conversion consistent.

This closes apache#4482
@cshannon cshannon added this to To do in 3.1.0 via automation Apr 26, 2024
cshannon added a commit to cshannon/accumulo that referenced this issue Apr 26, 2024
@cshannon
Create a SteadyTime type in the Manager
6db0a42 
This replaces Manager.getSteadyTime() long value with a concrete type to
make it more apparent what time is being used. The serialization
and deserialization logic have been encapsulated as methods to make the
conversion consistent.

This closes apache#4482
@cshannon cshannon mentioned this issue Apr 26, 2024
Merged
cshannon added a commit that referenced this issue May 10, 2024
@cshannon
Create a SteadyTime type in the Manager (#4494)
6dcf84e 
* Create a SteadyTime type in the Manager

This replaces Manager.getSteadyTime() long value with a concrete type to
make it more apparent what time is being used. The serialization
and deserialization logic have been encapsulated as methods to make the
conversion consistent.

This closes #4482
3.1.0 automation moved this from To do to Done May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cshannon cshannon

Labels
None yet
Projects
3.1.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create a SteadyTime type in the Manager cshannon/accumulo
2 participants
@cshannon @keith-turner