Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when a tablet has been in the migrating state for an extended period #4539

Closed
keith-turner opened this issue May 9, 2024 · 0 comments
Closed
Assignees
Labels
enhancement This issue describes a new feature, improvement, or optimization.

Comments

@keith-turner
Copy link
Contributor

keith-turner commented May 9, 2024

Is your feature request related to a problem? Please describe.

The manager tracks a set of migrating tablets in memory for balancing purposes. When a tablet has been in this set for an extended period, it would be useful to log that. For example if a tablet X has been in the migrating set for 30 mins, it would be useful to log that in order to diagnose the problem.

Describe the solution you'd like

This could be done in two possible ways. Tablet severs could log when a tablet is taking too long to unload AND/OR the manager could log when something is in the migrating set for too long. May be useful to do both.

@keith-turner keith-turner added the enhancement This issue describes a new feature, improvement, or optimization. label May 9, 2024
@keith-turner keith-turner added this to To do in 3.1.0 via automation May 9, 2024
@keith-turner keith-turner added this to To do in 2.1.3 via automation May 9, 2024
dlmarion added a commit that referenced this issue May 24, 2024
Created an abstract ConditionalLogger class with two implementations. The
EscalatingLogger will conditionally log at a higher level and the
deduplicating logger will conditionally suppress log messages. Wired up the
deduplicating logger in the UnloadTabletHandler to suppress multiple invocations
of unload and wired up the escalating logger in the TabletGroupWatcher when
the same tablet has been requested to be unloaded.

Closes #4539
@dlmarion dlmarion self-assigned this May 24, 2024
3.1.0 automation moved this from To do to Done May 24, 2024
2.1.3 automation moved this from To do to Done May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
2.1.3
Done
3.1.0
Done
Status: Done
Development

No branches or pull requests

2 participants