correctly handle first and last tablets in LinkingIterator #1260 #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LinkingIterator checks the structure of the AccumuloMetadata table as it is scans. It was not properly handling a split of the first tablet. It was also not ensuring the last tablet for a table was seen. This patch fixes those two issues. These issues were discovered while researching apache#1260, however I am not sure if these issues could have caused apache#1260.
ctubbsii
reviewed
Jul 11, 2019
core/src/main/java/org/apache/accumulo/core/metadata/schema/LinkingIterator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/LinkingIterator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/LinkingIterator.java
Outdated
Show resolved
Hide resolved
ctubbsii
reviewed
Jul 11, 2019
core/src/main/java/org/apache/accumulo/core/metadata/schema/LinkingIterator.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/metadata/schema/LinkingIterator.java
Outdated
Show resolved
Hide resolved
keith-turner
added a commit
to keith-turner/accumulo
that referenced
this pull request
Sep 27, 2019
Added unit test to excercise the code that checks the consistency of the metadata table during GC scans. Also added a check to ensure the last tablet was seen. This should cause an error to be thrown if the scanner stops returning data for any reason. These changes were already made in 2.0 in apache#1266. However the code in 1.9 is so different that they could not be backported, but had to be reimplelmented.
keith-turner
added a commit
that referenced
this pull request
Oct 10, 2019
Added unit test to exercise the code that checks the consistency of the metadata table during GC scans. Also added a check to ensure the last tablet was seen. This should cause an error to be thrown if the scanner stops returning data for any reason. These changes were already made in 2.0 in #1266. However the code in 1.9 is so different that they could not be back-ported, but had to be re-implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LinkingIterator checks the structure of the AccumuloMetadata table
as it is scans. It was not properly handling a split of the first
tablet. It was also not ensuring the last tablet for a table was seen.
This patch fixes those two issues. These issues were discovered while
researching #1260, however I am not sure if these issues could have
caused #1260.