Use isEmpty() rather than size()/length() checks. #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per SonarQube recommendations: Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant. The time complexity of any isEmpty() method implementation should be O(1) whereas some implementations of size() can be O(n).
milleruntime
approved these changes
Apr 20, 2020
ctubbsii
approved these changes
Apr 20, 2020
jmark99
added a commit
to jmark99/accumulo
that referenced
this pull request
Apr 23, 2020
This is a follow-up to apache#1590. After updating code to use isEmpty() this ticket re-factors to switch order of statements to remove the negation. Additionally 'if' statement negations were re-factored. A couple of cases where a statement contained double negations were updated also. The intent is to increase the clarity of the statements. This update does not alter the behavior of the code. Hopefully it just results in more readable code. Since this is primarily a stylistic update if there is opposition to it then it can be ignored and the ticket can be closed.
jmark99
added a commit
that referenced
this pull request
Apr 24, 2020
This is a follow-up to #1590. After updating code to use isEmpty() this ticket re-factors to switch order of statements to remove the negation. Additionally 'if' statement negations were re-factored. A couple of cases where a statement contained double negations were updated also. The intent is to increase the clarity of the statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per SonarQube recommendations:
Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant. The time complexity of any isEmpty() method implementation should be O(1) whereas some implementations of size() can be O(n).