ACCUMULO-4525: Replace meaningless method names #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: if you put the issue number like "ACCUMULO-4525", it will link this PR to the JIRA at https://issues.apache.org/jira/browse/ACCUMULO-4525 (this comment should trigger it, since the subject didn't). |
milleruntime
changed the title
milleruntime
changed the title
milleruntime
force-pushed
the
ACCUMULO-4525_2.0
branch
from
f5e9ee2
to
37ad8f5
Compare
ctubbsii
approved these changes
Nov 23, 2016
|
Passes "mvn clean verify -Psunny". Will leave open for a few more days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to learn the internals of Accumulo, I found a lot of the method names in Test to be confusing. I think Tests are an under utilized learning tool for newcomers. Many method names in Test were clearly chosen for brevity rather than clarity which I think is a bad habit that doesn't help new Accumulo developers.
This PR is for 2.0 (branch with the most changes). I have similar changes for 1.7 and 1.8 branches. Tests should be the same functionally but I wanted other devs to see the changes and get their opinions.