Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCUMULO-4703 Use formatter-maven-plugin 2.1.0.RC1 #314

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

ctubbsii
Copy link
Member

Upgrade to newest formatter, so javadocs are properly formatted.

Upgrade to newest formatter, so javadocs are properly formatted.
@ctubbsii ctubbsii self-assigned this Oct 23, 2017
@@ -945,7 +945,7 @@
<plugin>
<groupId>net.revelc.code.formatter</groupId>
<artifactId>formatter-maven-plugin</artifactId>
<version>2.0.1</version>
<version>2.1.0.RC1</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use a RC1 version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a name. Not an indication of status. For better or worse, it was released to Maven Central with that name and exists as a release there.

This version fixes the problem of not formatting javadocs.

I've mentioned my thoughts on the naming/release process on revelc/formatter-maven-plugin#242 ; I think we still need to iron out issues in that community about how releases are done, so it can have a more streamlined and consistent release process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just thinking: we can also bump to a newer version, if available, prior to release. For now, the one marked "RC1" is good enough to keep the master branch properly formatted during development.

@asfgit asfgit merged commit 41ec3e2 into apache:master Oct 23, 2017
@ctubbsii ctubbsii deleted the fix-javadoc-formatting branch October 23, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants