ACCUMULO-4546 Create default log message for IllegalTableTransitionException #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the IllegalTableTransitionException class within TableManager.java to print a default log message when exception is thrown. User also has option of supplying a custom message as well. Created a unit test as well.
…ception Updated the IllegalTableTransitionException class within TableManager.java to have a default log message when exception is thrown. User also has option of supplying a custom message. Created unit test. Moved location of an import in AccumuloTest.java to make mvn happy.
…xception
Updated the IllegalTableTransitionException class within TableManager.java to have
a default log message when exception is thrown. User also has option of supplying a
custom message. Created unit test.
Moved location of an import in AccumuloTest.java to make mvn happy.
…ception ACCUMULO-4546 Updated the IllegalTableTransitionException class within TableManager.java to print a default log message when exception is thrown. User also has option of supplying a custom message. Created unit test. Moved import in AccumuloTest.java to make mvn happy.
…ception ACCUMULO-4546 Updated the IllegalTableTransitionException class within TableManager.java to print a default log message when exception is thrown. User also has option of supplying a custom message. Created unit test. Moved import in AccumuloTest.java to make mvn happy.
…xception
Updated the IllegalTableTransitionException class within TableManager.java to have
a default log message when exception is thrown. User also has option of supplying a
custom message. Created unit test.
Moved location of an import in AccumuloTest.java to make mvn happy.
|
Can one of the admins verify this patch? |
keith-turner
approved these changes
Nov 28, 2017
| @Test | ||
| public void testIllegalTableTransitionExceptionEmptyMessage() { | ||
| try { | ||
| throw new TableManager.IllegalTableTransitionException(oldState, newState, ""); |
There was a problem hiding this comment.
In addition to "", could also try null.
There was a problem hiding this comment.
I went back and forth between null and the empty string. Both will work. I can go with either if you have a preference.
There was a problem hiding this comment.
I saw both were supported in the code. I was thinking could have test for both.
There was a problem hiding this comment.
Added additional unit test.
| this.oldState = oldState; | ||
| this.newState = newState; | ||
|
|
||
| String defaultMessage = "Error transitioning from " + oldState + " state to " + newState + " state"; |
There was a problem hiding this comment.
Could this be moved inside the else block?
…ception Moved the defaultMessage declaration inside the if/else block.
| this.oldState = oldState; | ||
| this.newState = newState; | ||
|
|
||
| if (message != null && !message.isEmpty()) |
There was a problem hiding this comment.
Could use StringUtils.isNotEmpty() from apache commons. Or even static import it so it just reads if(isNotEmpty(message))
There was a problem hiding this comment.
Thanks, @milleruntime . I like that better.
…ception Added unit test for null message. Also, updated message check to use StringUtils.isNotEmpty()
ctubbsii
approved these changes
Nov 28, 2017
milleruntime
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACCUMULO-4546 Create default log message for IllegalTableTransitionException
Updated the IllegalTableTransitionException class within TableManager.java to print
a default log message when exception is thrown. User also has option of supplying a
custom message. Created unit test.
Moved import in AccumuloTest.java to make mvn happy.