Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCUMULO-4742 Relocate bundled monitor resources #333

Merged
merged 1 commit into from Dec 7, 2017

Conversation

ctubbsii
Copy link
Member

@ctubbsii ctubbsii commented Dec 7, 2017

  • Place monitor resources in fully qualified package, to deconflict with
    other possible class path resources from other jars.
  • Add directory structure to bootstrap resources and add missing font
    files to fix resource loading of bootstrap.

@ctubbsii ctubbsii self-assigned this Dec 7, 2017
@asfgit
Copy link

asfgit commented Dec 7, 2017

Can one of the admins verify this patch?

* Place monitor resources in fully qualified package, to deconflict with
  other possible class path resources from other jars.
* Add directory structure to bootstrap resources and add missing font
  files to fix resource loading of bootstrap.
* Also remove remaining minimized flot files (ACCUMULO-4741) and
  included flot in the external resources section of the template.
@ctubbsii ctubbsii force-pushed the relocate-bundled-monitor-resources branch from 89c839a to 411c804 Compare December 7, 2017 21:29
@ctubbsii
Copy link
Member Author

ctubbsii commented Dec 7, 2017

I pushed a quick fix with an updated log message which mentions cleanup of flot minimized files and moving flot into the external resources section of the template. No code change from the initial PR. Just an updated log message.

Copy link
Contributor

@milleruntime milleruntime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and ran your branch locally. Looks good in Chrome and Firefox Quantum. The vertical dots on the right of the nav bar look good as well.

@asfgit asfgit merged commit 411c804 into apache:master Dec 7, 2017
@ctubbsii ctubbsii deleted the relocate-bundled-monitor-resources branch December 7, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants