ACCUMULO-1975 Refactor Property.createInstanceFromPropertyName into AccumuloConfiguration.instantiateClassProperty #351
Conversation
There was a problem hiding this comment.
The one in Property.java is actually the good one. A lot changed in this code since the original JIRA issue was created. Specifically, the ConfigurationTypeHelper class was created to assist converting String configuration values to specific types, and it was designed to properly fail if it a user-specified value was not able to be parsed. The one in AccumuloConfiguration.java suppresses exceptions silently, and could cause problems.
Instead of changing the existing code which calls Property.createInstanceFromPropertyName, the code which calls AccumuloConfiguration.instantiateClassProperty should be reviewed and modified to call the Property.createInstanceFromPropertyName, Property.createTableInstanceFromPropertyName, or another customized call to ConfigurationTypeHelper directly.
|
Oh ha okay I saw that Property.createInstanceFromPropertyName was only in 3 places so I just assumed. I will go through and review those. |
…ariant, in locations where instantiateClassProperty was used.
|
I believe I have replaced all the code in the appropriate places as well as removed AccumuloConfiguration.instantiateClassProperty method from the class. |
No description provided.