Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACCUMULO-3920 Deprecate mock components #40

Merged
merged 3 commits into from
Jul 30, 2015
Merged

ACCUMULO-3920 Deprecate mock components #40

merged 3 commits into from
Jul 30, 2015

Conversation

ctubbsii
Copy link
Member

@ctubbsii ctubbsii commented Jul 9, 2015

Done so far

  • Deprecate Accumulo Mock classes
  • Add javadoc to mock package to add additional details
  • Create DeprecationUtil to help migrate code which must continue to use mock
  • Minimize mock usage throughout the tests wherever possible
    • Use EasyMock in a few cases where it was possible to satisfy the test
    • Apply @Rule, @Before, etc. to reduce number of calls to MockInstance
  • Create replacement IteratorAdapter for use outside of mock

Could use help with

(most of these can be pretty readily identified in Eclipse with deprecation warnings shown)

  • Migrating FormatterCommandTest.java to avoid use of MockShell
  • Migrating MapReduce tests and other "heavyweight" tests to use MiniAccumuloCluster
  • Migrating other "lightweight" tests to use EasyMock

@asfbot
Copy link

asfbot commented Jul 9, 2015

Accumulo-Pull-Requests #85 ABORTED

@asfbot
Copy link

asfbot commented Jul 9, 2015

Accumulo-Pull-Requests #86 ABORTED

@asfbot
Copy link

asfbot commented Jul 9, 2015

Accumulo-Pull-Requests #87 ABORTED

@asfbot
Copy link

asfbot commented Jul 9, 2015

Accumulo-Pull-Requests #88 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 9, 2015

Accumulo-Pull-Requests #89 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 10, 2015

Accumulo-Pull-Requests #90 UNSTABLE
Looks like there's a problem with this pull request

@keith-turner
Copy link
Contributor

I am thinking we can drop IntersectingIteratorTest.testWithBatchScanner() because ExamplesIT.testShardedIndex() will test IntersectingIter using a real batch scanner in an IT. IntersectingIteratorTest.testWithBatchScanner() is testing IntersectingIter using the mock batch scanner. Alternatively if we want to treat this as a test of mock, we could just suppress warnings on the test and add a comment stating the test is intended to test the mock batch scanner.

@ctubbsii
Copy link
Member Author

Works for me. Let's drop the redundant test.

@keith-turner
Copy link
Contributor

I removed IntersectingIteratorTest.testWithBatchScanner() in 712f4e8. I checked coverge of IntersectingIterator before and after. It went from 73.8 to 73.6

@asfbot
Copy link

asfbot commented Jul 17, 2015

Accumulo-Pull-Requests #92 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 17, 2015

Accumulo-Pull-Requests #93 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 17, 2015

Accumulo-Pull-Requests #94 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 18, 2015

Accumulo-Pull-Requests #95 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 20, 2015

Accumulo-Pull-Requests #101 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 20, 2015

Accumulo-Pull-Requests #102 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 20, 2015

Accumulo-Pull-Requests #103 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 21, 2015

Accumulo-Pull-Requests #104 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 24, 2015

Accumulo-Pull-Requests #105 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 24, 2015

Accumulo-Pull-Requests #106 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 24, 2015

Accumulo-Pull-Requests #107 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 27, 2015

Accumulo-Pull-Requests #108 UNSTABLE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 27, 2015

Accumulo-Pull-Requests #109 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 28, 2015

Accumulo-Pull-Requests #110 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 28, 2015

Accumulo-Pull-Requests #111 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 28, 2015

Accumulo-Pull-Requests #112 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 28, 2015

Accumulo-Pull-Requests #113 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

Accumulo-Pull-Requests #114 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

Accumulo-Pull-Requests #115 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 29, 2015

Accumulo-Pull-Requests #116 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #117 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #118 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #119 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #120 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #121 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #122 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #123 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #124 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #125 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #126 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #127 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #128 SUCCESS
This pull request looks good

ctubbsii and others added 3 commits July 30, 2015 16:33
@ctubbsii
ACCUMULO-3920 Deprecate mock components
2556df3 
* Deprecate Accumulo Mock classes
* Add javadoc to mock package to add additional details
* Create DeprecationUtil to help migrate code which must continue to use mock
* Minimize mock usage throughout the tests wherever possible
  * Use EasyMock in a few cases where it was possible to satisfy the test
  * Apply @rule, @before, etc. to reduce number of calls to MockInstance
* Create replacement IteratorAdapter for use outside of mock
@keith-turner @ctubbsii
ACCUMULO-3920 moved some test away from mock
66c62e5
@ctubbsii
ACCUMULO-3920 Convert more tests from mock
cc3c011 
* Convert tests using mock to MiniAccumuloCluster
* Separate ITs from UTs, when possible
* Fix checkstyle/findbugs issues
@asfbot
Copy link

asfbot commented Jul 30, 2015

Accumulo-Pull-Requests #129 SUCCESS
This pull request looks good

@asfgit asfgit merged commit cc3c011 into apache:master Jul 30, 2015
asfgit pushed a commit that referenced this pull request Jul 30, 2015
@ctubbsii
Merge branch 'ACCUMULO-3920'
da8d8a8 
This closes #40
@ctubbsii ctubbsii deleted the ACCUMULO-3920 branch July 31, 2015 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ctubbsii @asfbot @keith-turner @asfgit