ACCUMULO-3389 Fix name in tsBatchDeleter #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also improved error message in IteratorSetting to include bad name
ctubbsii
approved these changes
Mar 20, 2018
| @@ -89,7 +89,7 @@ public String getName() { | |||
| */ | |||
| public void setName(String name) { | |||
| checkArgument(name != null, "name is null"); | |||
| checkArgument(!name.contains("."), "Iterator name cannot contain a dot/period"); | |||
| checkArgument(!name.contains("."), "Iterator name cannot contain a dot/period: " + name); | |||
| @@ -44,7 +44,7 @@ public TabletServerBatchDeleter(ClientContext context, String tableId, Authoriza | |||
| this.context = context; | |||
| this.tableId = tableId; | |||
| this.bwConfig = bwConfig; | |||
| super.addScanIterator(new IteratorSetting(Integer.MAX_VALUE, BatchDeleter.class.getName() + ".NOVALUE", SortedKeyIterator.class)); | |||
| super.addScanIterator(new IteratorSetting(Integer.MAX_VALUE, BatchDeleter.class.getName().replaceAll("[.]", "_") + "_NOVALUE", SortedKeyIterator.class)); | |||
There was a problem hiding this comment.
Probably don't need 2 underscores between class name and NOVALUE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered by the failure in TabletStateChangeIteratorIT