Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutation timestamp for valid GcCandidates #4113

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

ddanielr
Copy link
Contributor

GcCandidates are "Valid" when the filepaths they reference have been removed from HDFS.
Because the file no longer exists, the putDelete mutation should not include a timestamp to ensure no newer versions of that same GcCandidate are processed a second time.

Removes the timestamp from the putDelete mutation for valid GcCandidates
@ddanielr ddanielr added this to In progress in 2.1.3 via automation Dec 22, 2023
@ddanielr ddanielr linked an issue Dec 22, 2023 that may be closed by this pull request
@ctubbsii ctubbsii added this to In progress in 3.1.0 via automation Dec 27, 2023
Copy link
Contributor

@EdColeman EdColeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly could add comments inline what the delete mutation and with the timestamp is doing and why / when no timestamp is needed.

But the code LGTM.

@ddanielr ddanielr merged commit d973179 into apache:2.1 Dec 28, 2023
8 checks passed
3.1.0 automation moved this from In progress to Done Dec 28, 2023
2.1.3 automation moved this from In progress to Done Dec 28, 2023
@ddanielr ddanielr deleted the update-gc-mutation branch December 28, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.1.3
Done
3.1.0
Done
Development

Successfully merging this pull request may close these issues.

Delete referenced candidates in AccumuloGC
2 participants