Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImportConfiguration.builder().setKeepOffline() #4115

Merged
merged 1 commit into from Jan 5, 2024
Merged

Fix ImportConfiguration.builder().setKeepOffline() #4115

merged 1 commit into from Jan 5, 2024

Conversation

DomGarguilo
Copy link
Member

Fixes #4045

This PR adds logic to properly transition the state of a new table created via importTable() to offline (or online) depending on the value supplied via the ImportConfiguration.

This was corrected by the change in FinishImportTable where the table was never transitioned from the NEW to OFFLINE table state when the (then onlineTable) param was set.

Other changes:

  • added a check in the IT to make sure the new table is in the OFFLINE state instead of just "not online"
  • renamed the member variable from onlineTable to keepOffline for clarity and consistency

@DomGarguilo DomGarguilo self-assigned this Dec 22, 2023
@DomGarguilo DomGarguilo added this to In progress in 2.1.3 via automation Dec 22, 2023
@DomGarguilo DomGarguilo linked an issue Dec 22, 2023 that may be closed by this pull request
ImportConfiguration.builder().setKeepOffline(true) does not create a table offline - table stuck in NEW state #4045
Closed
@ctubbsii ctubbsii added this to In progress in 3.1.0 via automation Dec 27, 2023
@DomGarguilo DomGarguilo added the bug This issue has been verified to be a bug. label Jan 3, 2024
@DomGarguilo DomGarguilo mentioned this pull request Jan 5, 2024
Closed
@DomGarguilo DomGarguilo merged commit df26864 into apache:2.1 Jan 5, 2024
8 checks passed
3.1.0 automation moved this from In progress to Done Jan 5, 2024
2.1.3 automation moved this from In progress to Done Jan 5, 2024
@DomGarguilo DomGarguilo deleted the fixImportKeepOffline branch January 5, 2024 15:55
@DomGarguilo DomGarguilo mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-turner keith-turner keith-turner approved these changes

Assignees

@DomGarguilo DomGarguilo

Labels
bug This issue has been verified to be a bug.
Projects
2.1.3
Done
3.1.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportConfiguration.builder().setKeepOffline(true) does not create a table offline - table stuck in NEW state
2 participants
@DomGarguilo @keith-turner