Improve ThriftTransportPool shutdown speed #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlmarion
reviewed
May 15, 2024
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
Show resolved
Hide resolved
|
I think this change could target the 2.1 branch so that it gets included in the next 2.1 patch release. |
thanks, will rebase |
findepi
force-pushed
the
findepi/main/improve-thrifttransportpool-shutdown-speed-ed95f8
branch
from
70def43
to
395414a
Compare
dlmarion
reviewed
May 16, 2024
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/ThriftTransportPool.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/main/improve-thrifttransportpool-shutdown-speed-ed95f8
branch
from
395414a
to
88462c7
Compare
|
@findepi - we have a code formatter that runs as part of our build, and we verify that here, which is currently failing. Running |
Wake the "Thrift Connection Pool Checker" thread from sleeping during shutdown, so that it is joined quicker.
findepi
force-pushed
the
findepi/main/improve-thrifttransportpool-shutdown-speed-ed95f8
branch
from
88462c7
to
ffb2fb5
Compare
|
I kicked off a full IT build for this branch. |
|
Full IT build passed successfully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wake the "Thrift Connection Pool Checker" thread from sleeping during shutdown, so that it is joined quicker.