-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport server idle metric to 2.1 #4716
Conversation
Co-authored-by: Dave Marion <dlmarion@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4078 also had a change to MetricsIT.
core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java
Show resolved
Hide resolved
So far I have backported the changes as they exist in elasticity and tried to get the test working. Right now I can see the metric for the compactor and scan server in the test but am not seeing it for the tserver yet (no metric at all) and am not sure why. |
Looked into this a bit and it seems like micrometer only reports the metric after it changes and since the tserver never became idle, the value for this metric was never emitted. |
removing the WIP label as I think this is ready for review now. The only thing I need to fix is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a minor comment regarding the property description.
Fixes #4641
The changes in this PR will