Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCUMULO-4629 add exact deletes #588

Closed
wants to merge 2 commits into from

Conversation

keith-turner
Copy link
Contributor

No description provided.

@keith-turner keith-turner added v2.0.0 enhancement This issue describes a new feature, improvement, or optimization. labels Aug 8, 2018
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a write-up of what an "exact delete" is and what the overall design of this implementation is?

@keith-turner
Copy link
Contributor Author

Is there a write-up of what an "exact delete" is and what the overall design of this implementation is?

There is now : apache/accumulo-website#102

There is also what was on the JIRA issue.

@mikewalch
Copy link
Member

I really like exact deletes. I think it would be a great feature to add. It just seems more useful if it was done on a per-mutation basis instead of changing the behavior of the table. It would be nice if users could choose between range and exact deletes.

If you are looking to improve performance by minimizing seeks for deletes, what about adding the option to turn off deletes for a table at creation time?

Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have similar thoughts as @mikewalch .

I think it would be sufficient to provide a per-table configuration to disable delete marker processing (can be enabled or disabled, by admin): FAIL or PROCESS.

The specific behavior when PROCESSing deletes could be directed by information stored in the value of a delete marker, and set with new putDelete APIs on mutation. (A future/follow-on change.)

We can mark this feature as experimental, because I'm not sure it is the best way to achieve the performance desired for applications which aren't expected to have delete markers. (A suggestion was made to possibly switch the order of the delete and timestamp dimensions of the key to achieve that performance.)

@keith-turner
Copy link
Contributor Author

@mikewalch and @ctubbsii I agree with your assessments. I opened #598 based on your comments.

@mikewalch mikewalch removed the v2.0.0 label Sep 5, 2018
@keith-turner keith-turner deleted the exact-deletes branch December 6, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants