ARTEMIS-3121 Avoid creation of unnecessary StringBuilder instance in

Netty#getProtocols() and simplify implementation
apache · Feb 19, 2021 · f9e23de · f9e23de
1 parent 3cbc225
commit f9e23de
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/...ver/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java b/...ver/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
@@ -862,18 +862,12 @@ public NettyAcceptor setShutdownTimeout(int shutdownTimeout) {
       return this;
    }
 
-   private static String getProtocols(Map<String, ProtocolManager> protocolManager) {
-      StringBuilder sb = new StringBuilder();
-      if (protocolManager != null) {
-         Set<String> strings = protocolManager.keySet();
-         for (String string : strings) {
-            if (sb.length() > 0) {
-               sb.append(",");
-            }
-            sb.append(string);
-         }
+   private static String getProtocols(final Map<String, ProtocolManager> protocolManagers) {
+      if (protocolManagers == null || protocolManagers.isEmpty()) {
+         return "";
       }
-      return sb.toString();
+
+      return String.join(",", protocolManagers.keySet());
    }
 
    // Inner classes -----------------------------------------------------------------------------