Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTEMIS-1243 Release ReferenceCounted messages #1353

Closed
wants to merge 1 commit into from
Closed

ARTEMIS-1243 Release ReferenceCounted messages #1353

wants to merge 1 commit into from

Conversation

hwaastad
Copy link

This time make PR build compliant

michaelandrepearce
michaelandrepearce reviewed Jun 20, 2017
View reviewed changes
Copy link
Contributor

@michaelandrepearce michaelandrepearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@michaelandrepearce
Copy link
Contributor

retest this please

@michaelandrepearce
Copy link
Contributor

damn it, seems there isn't installed https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin , seems build failed not due to code change but general infra issue.

@hwaastad if you update the git commit message e.g. prefix the jira ticket "ARTEMIS-XXX" which probably should be done anyhow, and then force push to your branch that should trigger another rebuild

@hwaastad
Copy link
Author

@michaelandrepearce
Sure,
will you create an jira issue?

@michaelandrepearce
Copy link
Contributor

If you goto https://issues.apache.org/jira/projects/ARTEMIS and create an account (if you don't have one already) you should be able to.

@hwaastad hwaastad changed the title Try to release if message is ReferenceCounted ARTEMIS-1243 Release ReferenceCounted messages Jun 21, 2017
@michaelandrepearce
Copy link
Contributor

LGTM to me.
Thanks @hwaastad great that you found the bottom of the issue with MQTT and even more awesome you're able to resolve it. Thanks for this :)

Im not a committer, will have to wait for @clebertsuconic to merge for us. But thanks again :)

@asfgit asfgit closed this in a8ecc9f Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelandrepearce michaelandrepearce michaelandrepearce left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwaastad @michaelandrepearce