ARTEMIS-1660: Remove oracle12 autoincrement from column id for journal tables

[graben]

No description provided.

[franz1981]

Please run the JDBC tests with Oracle 12 (now possible using the right sys properties) and fix the PR tile/message

[graben]

@franz1981 : sorry I don't understand what you would like to tell? Do you think the title is wrong? Do you think my patch is wrong?

[franz1981]

@graben

Please run the JDBC tests with Oracle 12 (now possible using the right sys properties)

Currently we're not supporting Oracle into the Jenkins CI hence please run the JDBC tests vs Oracle 12 to see if there is anything broken: in the latest master is possible to run all the tests against specific DBMS different from the embedded derby by using configurable system properties

and fix the PR title/message

The PR title is: "ARTEMIS-1660: Remove oracle12 autoincrement from column id for journa…"
and the comment is: "…l tables"

Please fix both (ie title and message) in order to have a complete title and a more esplicit message 👍

[graben]

Well, I'm actually not able to test against oracle 12 only have a oracle 11 express instance. But it is obvious that the autoincrement of id is wrong, since it is 1st managed by the broker and 2nd different to all other database types.

[franz1981]

@graben

Well, I'm actually not able to test against oracle 12 only have a oracle 11 express instance

It would be enough: it is just to validate the changes.

But it is obvious that the autoincrement of id is wrong, since it is 1st managed by the broker and 2nd different to all other database types.

Agree but would be anyway welcome at least a test round with the change.
I will ping @mtaylor and @jmesnil authors of most the SQL contained there to validate it: if they think that the change is safe as it seems, for me is ok 👍

[jmesnil]

FWIW, I copied the SQL statement from Artemis 2.4.0

activemq-artemis/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/oracle/Oracle12CSQLProvider.java

Line 26 in ec63189

private final String createJournalTableSQL = "CREATE TABLE " + tableName + " (id NUMBER(19) GENERATED BY DEFAULT ON NULL AS IDENTITY,recordType NUMBER(5),compactCount NUMBER(5),txId NUMBER(19),userRecordType NUMBER(5),variableSize NUMBER(10),record BLOB,txDataSize NUMBER(10),txData BLOB,txCheckNoRecords NUMBER(10),seq NUMBER(19))";

[graben]

@mtaylor: Any feedback on this?

[franz1981]

@graben @mtaylor was the right person that knows why the ID was configured in that way; I will check on the Oracle 12c doc about it in order to give you feedback ASAP 👍