[ARTEMIS-1724] Create Artemis Openwire client Karaf feature #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
reviewed
Mar 2, 2018
| <scope>test</scope> | ||
| <exclusions> | ||
| <exclusion> | ||
| <!--Let's compile against JMS 2--> |
There was a problem hiding this comment.
The comment says "JMS 2," but the artifactId references the 1.1 spec. This seems wrong.
There was a problem hiding this comment.
Hi @jbertram thanks for reviewing!
I'm excluding the JMS 1.1 artifact, so we are compiling against JMS 2 (which is brought on the classpath transitively by artemis-jms-client). It was causing compiling issues because javax.jms.Connection doesn't implement AutoCloseable in JMS 1.1 whereas it does in JMS 2 which makes it possible to use in try-with-resources statements.
Thanks!
There was a problem hiding this comment.
Sorry about that. I didn't notice the exclusion. Makes perfect sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARTEMIS-1724
Thanks!