ARTEMIS-3716 move e2e tests to e2e-tests module #3980
Conversation
|
IMO this needs a Jira. At the very least it needs a rebase to pick up 67c9df1 which should allow the build checks to finish normally. Also, please update the commit message to follow the recommendations from the hacking guide. Thanks! |
tlbueno
changed the title
Thank you for the suggestions! |
|
@tlbueno the e2e-tests should only run if you enable the profile -De2e-tests.. the fast tests are failing on the PR check I want to make sure there are no compilation or check-stye issues introduced.. but we should not run the e2e-tests on the GitHub actions. |
Move all tests which are related to end-to-end testing from smoke-tests module to a new module named e2e-tests. These e2e tests are those which are dependent of ContainerService class. ContainerService class uses artemis inside a container by using the testcontainers library and for that reason these tests are usually a quite slow and tecnically they are not a smoke test. The new e2e-tests module is part of tests module but it is not enabled by default and to get executed it requires the e2e-tests profile specification on maven command.
@clebertsuconic now I think it is correct. The e2e-tests are getting built (compiled/verified) but not executed unless the -Pe2e-tests is provided. |
| <modules> | ||
| <module>e2e-tests</module> | ||
| </modules> |
There was a problem hiding this comment.
this is moot and it could be removed...
I'm removing it as I merge your commit.
Move all tests which are related to end-to-end testing from smoke-tests module to a new e2e-tests module.
These e2e tests are those which are dependent of ContainerService class. ContainerService class uses artemis inside a container by using the testcontainers library and for that reason these tests are usually a quite slow and tecnically they are not a smoke test.
The new e2e-tests module is part of tests module but it is not enabled by default and to get executed it requires the e2e-tests profile specification on maven command.