ARTEMIS-3591: stop paging checkMemory task executing twice #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // We check again to avoid a race condition where the size can come down just after the element | ||
| // has been added, but the check to execute was done before the element was added | ||
| // NOTE! We do not fix this race by locking the whole thing, doing this check provides | ||
| // MUCH better performance in a highly concurrent environment | ||
| if (!pagingManager.isGlobalFull() && (sizeInBytes.get() < maxSize || maxSize < 0)) { | ||
| // run it now | ||
| runWhenAvailable.run(); | ||
| atomicRunWhenAvailable.run(); |
There was a problem hiding this comment.
Ohhh... I thought you had a more complex case involved on this.
Thanks for this.
There was a problem hiding this comment.
Nope just the obvious cases mentioned on the JIRA, spotted when reading it for some older PR (dont recall which). Theres probably a few different paths it can happen, but the most basic solution used here hits the general issue. Took a lot longer to come up with a reliable test to exercise the problem than to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop paging checkMemory task executing twice in some cases.