Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTEMIS-3720 Max Number Of Messages on a deciding policy for paging (global and address-settings) #3983

Merged
merged 2 commits into from
Mar 18, 2022
Merged

ARTEMIS-3720 Max Number Of Messages on a deciding policy for paging (global and address-settings) #3983

merged 2 commits into from
Mar 18, 2022

Conversation

clebertsuconic
Copy link
Contributor

No description provided.

@clebertsuconic clebertsuconic force-pushed the ARTEMIS-3720 branch 3 times, most recently from ce0e415 to 1e65423 Compare March 11, 2022 21:55
@clebertsuconic
Copy link
Contributor Author

@gemmellr you mentioned me the other day that Page would run a task twice when releasing max-size on blocking. This would address that I think (as well)

@gemmellr
Copy link
Member

Dont think I did? Oh....actually, do you mean https://issues.apache.org/jira/browse/ARTEMIS-3591 from a while back? I had forgotten about that. Skimming the change here, it doesnt seem like it would directly address that.

@clebertsuconic
Copy link
Contributor Author

@gemmellr there is an atomic flag on a new class called SizeAwareMetric (something like that). I don't have a test for the issue you reported but this could address that.

@clebertsuconic clebertsuconic force-pushed the ARTEMIS-3720 branch 6 times, most recently from 33159ab to d2323ff Compare March 14, 2022 15:26
@gemmellr
Copy link
Member

@gemmellr there is an atomic flag on a new class called SizeAwareMetric (something like that). I don't have a test for the issue you reported but this could address that.

I've added a test and the trivial fix in #3985

@clebertsuconic clebertsuconic force-pushed the ARTEMIS-3720 branch 5 times, most recently from 1ac527d to 7a467cd Compare March 15, 2022 14:02
@clebertsuconic
Copy link
Contributor Author

Oops... I need to add tests for the parsing.. and I forgot to change the XSD for the address-settings

@clebertsuconic
Copy link
Contributor Author

I fixed the parsing... I will look into docs...

@clebertsuconic
Copy link
Contributor Author

@jbertram I applied the changed

gemmellr
gemmellr reviewed Mar 16, 2022
View reviewed changes
artemis-commons/src/test/java/org/apache/activemq/artemis/utils/SizeAwareMetricTest.java Outdated Show resolved Hide resolved
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/PagingManager.java Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-server/src/main/resources/schema/artemis-configuration.xsd Outdated Show resolved Hide resolved
artemis-server/src/main/resources/schema/artemis-configuration.xsd Show resolved Hide resolved
docs/user-manual/en/paging.md Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
@clebertsuconic clebertsuconic marked this pull request as draft March 17, 2022 15:26
@clebertsuconic clebertsuconic force-pushed the ARTEMIS-3720 branch 7 times, most recently from ba55f12 to 57f2618 Compare March 17, 2022 22:44
@clebertsuconic clebertsuconic marked this pull request as ready for review March 17, 2022 22:50
gemmellr
gemmellr reviewed Mar 18, 2022
View reviewed changes
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SizeAwareMetric.java Outdated Show resolved Hide resolved
@clebertsuconic clebertsuconic force-pushed the ARTEMIS-3720 branch 2 times, most recently from 98d209d to 6c1a24f Compare March 18, 2022 14:21
@clebertsuconic clebertsuconic force-pushed the ARTEMIS-3720 branch 8 times, most recently from 0342d35 to c538f25 Compare March 18, 2022 19:37
@clebertsuconic clebertsuconic merged commit 5bba1fb into apache:main Mar 18, 2022
@clebertsuconic clebertsuconic deleted the ARTEMIS-3720 branch March 21, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbertram jbertram jbertram left review comments

@gemmellr gemmellr gemmellr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clebertsuconic @gemmellr @jbertram