Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARTEMIS-3700]: Provinding a JakartaEE 10 implementation. #4057

Merged
merged 1 commit into from
May 23, 2022

Conversation

ehsavoie
Copy link
Contributor

  • Upgrading the API to Jakarta Messaging 3.1.0
  • Updating the metadata to 3.1.0

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3700

@clebertsuconic
Copy link
Contributor

@ehsavoie it seems the API Is not available on maven.

Can you rebase and push -f so this gets executed again?

@ehsavoie
Copy link
Contributor Author

ehsavoie commented May 4, 2022

@clebertsuconic it is not available until the official release (next week should be ok)

@gemmellr
Copy link
Member

The staged spec jar was actually released so you should be able to update this now @ehsavoie

https://repo1.maven.org/maven2/jakarta/jms/jakarta.jms-api/3.1.0/

@ehsavoie ehsavoie marked this pull request as ready for review May 23, 2022 09:58
@ehsavoie
Copy link
Contributor Author

thanks @gemmellr :)

@gemmellr
Copy link
Member

@ehsavoie I was implicitly suggesting you rebase etc so its up to date and actually builds etc ;)

* Upgrading the API to Jakarta Messaging 3.1.0
* Updating the metadata to 3.1.0

Jira: https://issues.apache.org/jira/browse/ARTEMIS-3700
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@ehsavoie
Copy link
Contributor Author

Well there was not conflict wit the current main so i didn't rebase :) but i didn't know how to relaunch the CI.

@gemmellr
Copy link
Member

Well there was not conflict wit the current main so i didn't rebase :)

PR commits always get rebased for artemis so its best if you do so its up to date.

but i didn't know how to relaunch the CI.

By pushing an update :)

@clebertsuconic
Copy link
Contributor

@ehsavoie easiest way:

git pull --rebase upstream main
git push origin -f

if you did not have an update from main (still rebase):

git commit --amend
git push origin -f

that will update the commit ID and make the build to re-launch

@clebertsuconic
Copy link
Contributor

although I was able to re-launch all jobs.. but I guess Robbie already did that anyways.

@gemmellr
Copy link
Member

I didnt (dont have write access set up), Emmanuel had pushed when commenting about previously not.

@clebertsuconic
Copy link
Contributor

@gemmellr Ohhh.. I thought he was asking to relaunch the jobs... sorry I misunderstood what he meant.. I was fast reading all my emails and I misunderstood it.. my bad.

@clebertsuconic clebertsuconic merged commit de15423 into apache:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants