Use varargs for log parameters instead of new Object[]
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some log statements where called with a combination of `new Object[] {...}` and
an exception. That lead to a misinterpretation of those parameters. The first
object array is considered to be the first argument and the exception the second
parameter of the format string.
It should have been interpreted as the members of the object array as the parameters
for the format string and the exception as the exception itself.
So for example:
LOG.info("User {} has done {}", new Object[] {"A", "something"}, e);
would log something like:
User [A, something] has done java.lang.RuntimeException: OOps
…param The first log format string in this commit has more placeholder than parameters. I added one that I think is the correct one, but please check before committing this one.
…cue exception This was again a case, where the object array would put the exception parameter into a place where it would be taken as the second parameter and not used as intended.
FSchumacher
force-pushed
the
wrong-log-arguments
branch
from
fb6646b
to
4ce6bfe
Compare
|
Superseeded by PR #631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some log statements where called with a combination of
new Object[] {...}andan exception. That lead to a misinterpretation of those parameters. The first
object array is considered to be the first argument and the exception the second
parameter of the format string.
It should have been interpreted as the members of the object array as the parameters
for the format string and the exception as the exception itself.
So for example:
would log something like: