Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend EXPLAIN and add config param to switch transformation of property filter #1262

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Extend EXPLAIN and add config param to switch transformation of property filter #1262

merged 2 commits into from
Oct 16, 2023

Commits on Oct 5, 2023

  1. Add explain options 

    Explain command in the following format is supported
now:
    `EXPLAIN (VERBOSE, COSTS OFF, FORMAT XML) ...`

Note that, this is basically Postgres' EXPLAIN command,
and the purpose of this is to support debugging and
regression tests.
    @rafsun42
    rafsun42 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6c25e8f View commit details
    Browse the repository at this point in the history

  2. Add config param to switch transformation method of property filter 

    When the `age.enable_containment` parameter is on, the agtype
containment operator is used to transform property filter. When off,
access operator is used instead. The former case is preferable for
GIN index, and the later for BTREE expression index.

The idea of replacing containment with access operator in order to
support BTREE index is taken from a patch by Josh Innis.

A note on regression testing- although there are test cases for the
`age.enable_containment` parameter, sometimes it may be useful to
set this parameter before running any tests (not just the ones related
to it). For example, when the logic related to property transformation
changes. It can be set in the `age_regression.conf` file.
    @rafsun42
    rafsun42 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3c6e9db View commit details
    Browse the repository at this point in the history