Fix memory leaks in MERGE (merge_edge & merge_vertex) #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed memory leaks in MERGE. Specifically in the merge_edge and merge_vertex functions. These functions will now throw error messages rather than attempt to store values in the wrong locations. Additionally, added some code to make it easier to debug the source of an incorrect tuple position. Fixed bad regression tests. Updated code formatting.
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed memory leaks in MERGE. Specifically in the merge_edge and merge_vertex functions. These functions will now throw error messages rather than attempt to store values in the wrong locations. Additionally, added some code to make it easier to debug the source of an incorrect tuple position.
Fixed bad regression tests.
Updated code formatting.