Feature/ftp transport - FTP Transport protocol PR #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkiran292
changed the title
|
You have missed including the dependency for your FTP-transport under mft-agent/pom.xml |
I have added it! |
dinukadesilva
approved these changes
May 1, 2020
...er/src/main/java/org/apache/airavata/mft/resource/server/backend/sql/SQLResourceBackend.java
Show resolved
Hide resolved
DImuthuUpe
requested changes
May 1, 2020
...c/main/java/org/apache/airavata/mft/resource/server/backend/sql/entity/FTPStorageEntity.java
Show resolved
Hide resolved
| @@ -0,0 +1,57 @@ | |||
| package org.apache.airavata.mft.resource.server.backend.sql.entity; | |||
There was a problem hiding this comment.
Agreed! I will add the license headers
There was a problem hiding this comment.
Done! Pushed the changes
Closed
|
Looks good to me. Great work. Thanks |
| @@ -55,4 +55,9 @@ | |||
| public DropboxSecret createDropboxSecret(DropboxSecretCreateRequest request) throws Exception; | |||
| public boolean updateDropboxSecret(DropboxSecretUpdateRequest request) throws Exception; | |||
| public boolean deleteDropboxSecret(DropboxSecretDeleteRequest request) throws Exception; | |||
|
|
|||
| Optional<FTPSecret> getFTPSecret(FTPSecretGetRequest request) throws Exception; | |||
There was a problem hiding this comment.
@gkiran292 @DImuthuUpe
For keeping it uniform, I guess adding a public modifier to each of these declarations would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTP transport changes.
@DImuthuUpe Please review this.