Bugfix/mft transports #15
Conversation
|
|
||
| @Override | ||
| public Optional<FTPResource> getFTPResource(FTPResourceGetRequest request) throws Exception { | ||
| InputStream inputStream = FileBasedResourceBackend.class.getClassLoader().getResourceAsStream("resources.json"); |
There was a problem hiding this comment.
Minor Suggestion: instead of hard coding the name of resource file use field resourceFile
There was a problem hiding this comment.
Done I have changed it
There was a problem hiding this comment.
Since this branch is taken out of feature/ftp-transport. I have made the changes there as it is related to that I am attaching my commit here
68897a1
Yes, Dimuthu. I checked out a branch from the feature/FTP-transport. That is why you are able to see those FTP changes too. I will close this PR and raise the PR after FTP is merged. But my question is whether the PR would still show the FTP related file changes after the FTP changes are merged to master. I am sure I need to pull from the feature/FTP-transport again as I have made changes to cater to the FTP-transport PR reviews. If it shows FTP related files even after the PR (#13) is merged, I will close this PR and raise another. |
There were streams that were not closed and redundant use of outputstream.flush()
outputstream.close() does flush internally!