Skip to content

Commit

Permalink
Resolve deprecation warning re Table.exists() (#26616)
Browse files Browse the repository at this point in the history
The deprecation warning tells us we need to change Table.exists() to Inspector.has_table().  It turns out we're already using the right method, but we weren't passing it the right object.  It wants a table name but we were giving it a table.

(cherry picked from commit 2388bd7)
  • Loading branch information
dstandish authored and jedcunningham committed Sep 27, 2022
1 parent 5e990fd commit 15dd9a8
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 64 deletions.
36 changes: 0 additions & 36 deletions airflow/compat/sqlalchemy.py

This file was deleted.

3 changes: 1 addition & 2 deletions airflow/migrations/versions/0001_1_5_0_current_schema.py
Expand Up @@ -26,9 +26,8 @@

import sqlalchemy as sa
from alembic import op
from sqlalchemy import func
from sqlalchemy import func, inspect

from airflow.compat.sqlalchemy import inspect
from airflow.migrations.db_types import StringID

# revision identifiers, used by Alembic.
Expand Down
Expand Up @@ -26,8 +26,7 @@

import sqlalchemy as sa
from alembic import op

from airflow.compat.sqlalchemy import inspect
from sqlalchemy import inspect

# revision identifiers, used by Alembic.
revision = '1507a7289a2f'
Expand Down
Expand Up @@ -25,11 +25,10 @@

import sqlalchemy as sa
from alembic import op
from sqlalchemy import Column, Integer, String
from sqlalchemy import Column, Integer, String, inspect
from sqlalchemy.ext.declarative import declarative_base

from airflow import settings
from airflow.compat.sqlalchemy import inspect
from airflow.models import DagBag

# revision identifiers, used by Alembic.
Expand Down
Expand Up @@ -25,8 +25,7 @@

import sqlalchemy as sa
from alembic import op

from airflow.compat.sqlalchemy import inspect
from sqlalchemy import inspect

# revision identifiers, used by Alembic.
revision = '33ae817a1ff4'
Expand Down
3 changes: 1 addition & 2 deletions airflow/migrations/versions/0057_1_10_13_add_fab_tables.py
Expand Up @@ -26,8 +26,7 @@

import sqlalchemy as sa
from alembic import op

from airflow.compat.sqlalchemy import inspect
from sqlalchemy import inspect

# revision identifiers, used by Alembic.
revision = '92c57b58940d'
Expand Down
Expand Up @@ -26,8 +26,8 @@

import sqlalchemy as sa
from alembic import op
from sqlalchemy import inspect

from airflow.compat.sqlalchemy import inspect
from airflow.migrations.db_types import StringID

# revision identifiers, used by Alembic.
Expand Down
Expand Up @@ -25,10 +25,9 @@

import sqlalchemy as sa
from alembic import op
from sqlalchemy import inspect
from sqlalchemy.dialects import mysql

from airflow.compat.sqlalchemy import inspect

# revision identifiers, used by Alembic.
revision = 'cf5dc11e79ad'
down_revision = '03afc6b6f902'
Expand Down
Expand Up @@ -27,9 +27,7 @@
from collections import defaultdict

from alembic import op
from sqlalchemy import Column, Integer

from airflow.compat.sqlalchemy import inspect
from sqlalchemy import Column, Integer, inspect

# revision identifiers, used by Alembic.
revision = 'bbf4a7ad0465'
Expand Down
Expand Up @@ -27,10 +27,9 @@

import sqlalchemy as sa
from alembic import op
from sqlalchemy import Column, Integer, String
from sqlalchemy import Column, Integer, String, inspect
from sqlalchemy.ext.declarative import declarative_base

from airflow.compat.sqlalchemy import inspect
from airflow.utils.types import DagRunType

# revision identifiers, used by Alembic.
Expand Down
Expand Up @@ -26,9 +26,8 @@

import sqlalchemy as sa
from alembic import op
from sqlalchemy import func
from sqlalchemy import func, inspect

from airflow.compat.sqlalchemy import inspect
from airflow.migrations.db_types import TIMESTAMP, StringID

# revision identifiers, used by Alembic.
Expand Down
Expand Up @@ -26,8 +26,7 @@

import sqlalchemy as sa
from alembic import op

from airflow.compat.sqlalchemy import inspect
from sqlalchemy import inspect

# revision identifiers, used by Alembic.
revision = 'bef4f3d11e8b'
Expand Down
3 changes: 1 addition & 2 deletions airflow/utils/db.py
Expand Up @@ -33,7 +33,6 @@

import airflow
from airflow import settings
from airflow.compat.sqlalchemy import has_table
from airflow.configuration import conf
from airflow.exceptions import AirflowException
from airflow.models import import_all_models
Expand Down Expand Up @@ -1643,7 +1642,7 @@ def drop_airflow_models(connection):

migration_ctx = MigrationContext.configure(connection)
version = migration_ctx._version
if has_table(connection, version):
if inspect(connection).has_table(version.name):
version.drop(connection)


Expand Down
5 changes: 2 additions & 3 deletions airflow/www/fab_security/sqla/manager.py
Expand Up @@ -22,11 +22,10 @@
from flask_appbuilder import const as c
from flask_appbuilder.models.sqla import Base
from flask_appbuilder.models.sqla.interface import SQLAInterface
from sqlalchemy import and_, func, literal
from sqlalchemy import and_, func, inspect, literal
from sqlalchemy.orm.exc import MultipleResultsFound
from werkzeug.security import generate_password_hash

from airflow.compat import sqlalchemy as sqla_compat
from airflow.www.fab_security.manager import BaseSecurityManager
from airflow.www.fab_security.sqla.models import (
Action,
Expand Down Expand Up @@ -99,7 +98,7 @@ def register_views(self):
def create_db(self):
try:
engine = self.get_session.get_bind(mapper=None, clause=None)
inspector = sqla_compat.inspect(engine)
inspector = inspect(engine)
if "ab_user" not in inspector.get_table_names():
log.info(c.LOGMSG_INF_SEC_NO_DB)
Base.metadata.create_all(engine)
Expand Down
2 changes: 1 addition & 1 deletion docs/apache-airflow/img/airflow_erd.sha256
@@ -1 +1 @@
866390aad1d155c75b4283c4d50ff56fb1f210f21dcd0e0955984bd08f26ac5c
543fe0db520047b59d9d036b17d54b07f1031a2b6ef1f46dcd2ae970f14ab0e6

0 comments on commit 15dd9a8

Please sign in to comment.