Skip to content

Commit

Permalink
Disable fail-fast on pushing images to docker cache (#24005)
Browse files Browse the repository at this point in the history
There is an issue with pushing cache to docker registry that
is connected to containerd bug but started to appear more
frequently recently (as evidenced for example by
https://github.community/t/buildx-failed-with-error-cannot-reuse-body-request-must-be-retried/253178
). The issue is still open in containerd:
containerd/containerd#5978.

Until it if fixed, we disable fail-fast on pushing cache
so that even if it happens, we just have to re-run that single
python version that actually failed. Currently there is a much
lower chance of success because all 4 build have to succeed.

(cherry picked from commit ae343fa)
  • Loading branch information
potiuk authored and ephraimbuddy committed May 30, 2022
1 parent 7fe7f6a commit 312b7f3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1656,6 +1656,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
- docs
if: needs.build-info.outputs.mergeRun == 'true'
strategy:
fail-fast: false
matrix:
python-version: ${{ fromJson(needs.build-info.outputs.pythonVersions) }}
env:
Expand Down

0 comments on commit 312b7f3

Please sign in to comment.