Skip to content

Commit

Permalink
Remove a deprecated option from BigQueryHook.get_pandas_df (#33819)
Browse files Browse the repository at this point in the history
* Deleted a deprecated parameter.

`verbose` will be removed. (pandas_gbq.read_gbq)
  • Loading branch information
RyuSA committed Aug 31, 2023
1 parent 1969eaf commit 3b86842
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions airflow/providers/google/cloud/hooks/bigquery.py
Expand Up @@ -268,9 +268,7 @@ def get_pandas_df(

credentials, project_id = self.get_credentials_and_project_id()

return read_gbq(
sql, project_id=project_id, dialect=dialect, verbose=False, credentials=credentials, **kwargs
)
return read_gbq(sql, project_id=project_id, dialect=dialect, credentials=credentials, **kwargs)

@GoogleBaseHook.fallback_to_default_project_id
def table_exists(self, dataset_id: str, table_id: str, project_id: str) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion tests/providers/google/cloud/hooks/test_bigquery.py
Expand Up @@ -147,7 +147,7 @@ def test_get_pandas_df(self, mock_read_gbq):
self.hook.get_pandas_df("select 1")

mock_read_gbq.assert_called_once_with(
"select 1", credentials=CREDENTIALS, dialect="legacy", project_id=PROJECT_ID, verbose=False
"select 1", credentials=CREDENTIALS, dialect="legacy", project_id=PROJECT_ID
)

@mock.patch("airflow.providers.google.cloud.hooks.bigquery.BigQueryHook.get_service")
Expand Down

0 comments on commit 3b86842

Please sign in to comment.