Ensure include_deferred is not nullable (#33280)

* Ensure include_deferred is not nullable This uses a multi-step process to introduce the NOT NULL constraint to the column, needed due to MSSQL restrictions. * MSSQL does not even support boolean literals * Postgres does not support 0 as boolean This is fine. SQL is fun. * Wrap raw SQL in text()
apache · Aug 10, 2023 · 4f6d597 · 4f6d597
1 parent 369b9bc
commit 4f6d597
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/airflow/migrations/versions/0128_2_7_0_add_include_deferred_column_to_pool.py b/airflow/migrations/versions/0128_2_7_0_add_include_deferred_column_to_pool.py
@@ -39,7 +39,11 @@
 def upgrade():
     """Apply add include_deferred column to pool"""
     with op.batch_alter_table("slot_pool") as batch_op:
-        batch_op.add_column(sa.Column("include_deferred", sa.Boolean, default=False))
+        batch_op.add_column(sa.Column("include_deferred", sa.Boolean))
+    # Different databases support different literal for FALSE. This is fine.
+    op.execute(sa.text(f"UPDATE slot_pool SET include_deferred = {sa.false().compile(op.get_bind())}"))
+    with op.batch_alter_table("slot_pool") as batch_op:
+        batch_op.alter_column("include_deferred", existing_type=sa.Boolean, nullable=False)
 
 
 def downgrade():

diff --git a/docs/apache-airflow/img/airflow_erd.sha256 b/docs/apache-airflow/img/airflow_erd.sha256
@@ -1 +1 @@
-52b0e45032fb1c60274374e0114cf199dfb759adc0a4fe32964136347457506a
+266a8533dca6d9c7e984341bfe29e99f29217e44529455a49e7c4a5faccdcdf3
diff --git a/docs/apache-airflow/img/airflow_erd.svg b/docs/apache-airflow/img/airflow_erd.svg