typo: wrong OpenLineage facet key in spec (#39782)

Signed-off-by: Kacper Muda <mudakacper@gmail.com>
apache · May 23, 2024 · 57dab13 · 57dab13
1 parent 61e9070
commit 57dab13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/airflow/providers/google/cloud/openlineage/BigQueryErrorRunFacet.json b/airflow/providers/google/cloud/openlineage/BigQueryErrorRunFacet.json
@@ -23,7 +23,7 @@
     },
     "type": "object",
     "properties": {
-      "bigQueryJob": {
+      "bigQuery_error": {
         "$ref": "#/$defs/BigQueryErrorRunFacet"
       }
     }

diff --git a/airflow/providers/google/cloud/openlineage/utils.py b/airflow/providers/google/cloud/openlineage/utils.py
@@ -269,7 +269,7 @@ def get_facets(self, job_id: str):
             if hasattr(self, "log"):
                 self.log.warning("Cannot retrieve job details from BigQuery.Client. %s", e, exc_info=True)
             exception_msg = traceback.format_exc()
-            # TODO: remove ErrorMessageRunFacet in next release
+            # TODO: remove BigQueryErrorRunFacet in next release
             run_facets.update(
                 {
                     "errorMessage": ErrorMessageRunFacet(
@@ -282,10 +282,6 @@ def get_facets(self, job_id: str):
                 }
             )
         deduplicated_outputs = self._deduplicate_outputs(outputs)
-        # For complex scripts there can be multiple outputs - in that case keep them all in `outputs` and
-        # leave the `output` empty to avoid providing misleading information. When the script has a single
-        # output (f.e. a single statement with some variable declarations), treat it as a regular non-script
-        # job and put the output in `output` as an addition to new `outputs`. `output` is deprecated.
         return inputs, deduplicated_outputs, run_facets
 
     def _deduplicate_outputs(self, outputs: list[Dataset | None]) -> list[Dataset]: