Skip to content

Commit

Permalink
Use selectinload in trigger
Browse files Browse the repository at this point in the history
  • Loading branch information
Joseph Ang committed Jun 28, 2024
1 parent 8d5dbaa commit 5a85601
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions airflow/models/trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from typing import TYPE_CHECKING, Any, Iterable

from sqlalchemy import Column, Integer, String, Text, delete, func, or_, select, update
from sqlalchemy.orm import joinedload, relationship
from sqlalchemy.orm import joinedload, relationship, selectinload
from sqlalchemy.sql.functions import coalesce

from airflow.api_internal.internal_api_call import internal_api_call
Expand Down Expand Up @@ -74,7 +74,7 @@ class Trigger(Base):
uselist=False,
)

task_instance = relationship("TaskInstance", back_populates="trigger", lazy="joined", uselist=False)
task_instance = relationship("TaskInstance", back_populates="trigger", lazy="selectin", uselist=False)

def __init__(
self,
Expand Down Expand Up @@ -150,7 +150,7 @@ def bulk_fetch(cls, ids: Iterable[int], session: Session = NEW_SESSION) -> dict[
select(cls)
.where(cls.id.in_(ids))
.options(
joinedload(cls.task_instance)
selectinload(cls.task_instance)
.joinedload(TaskInstance.trigger)
.joinedload(Trigger.triggerer_job)
)
Expand Down

0 comments on commit 5a85601

Please sign in to comment.