Sanitize beeline principal parameter (#31983)

Similar to other parameters of Beeline, principal should not contain the semicolon.
apache · Jun 18, 2023 · 6724eeb · 6724eeb
1 parent a298874
commit 6724eeb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/airflow/providers/apache/hive/hooks/hive.py b/airflow/providers/apache/hive/hooks/hive.py
@@ -150,9 +150,9 @@ def _prepare_cli_cmd(self) -> list[Any]:
                 template = conn.extra_dejson.get("principal", "hive/_HOST@EXAMPLE.COM")
                 if "_HOST" in template:
                     template = utils.replace_hostname_pattern(utils.get_components(template))
-
                 proxy_user = self._get_proxy_user()
-
+                if ";" in template:
+                    raise RuntimeError("The principal should not contain the ';' character")
                 jdbc_url += f";principal={template};{proxy_user}"
             elif self.auth:
                 jdbc_url += ";auth=" + self.auth

diff --git a/tests/providers/apache/hive/hooks/test_hive.py b/tests/providers/apache/hive/hooks/test_hive.py
@@ -891,3 +891,14 @@ def test_get_proxy_user_value(self):
 
         # Verify
         assert "hive.server2.proxy.user=a_user_proxy" in result[2]
+
+    def test_get_wrong_principal(self):
+        hook = MockHiveCliHook()
+        returner = mock.MagicMock()
+        returner.extra_dejson = {"principal": "principal with ; semicolon"}
+        hook.use_beeline = True
+        hook.conn = returner
+
+        # Run
+        with pytest.raises(RuntimeError, match="The principal should not contain the ';' character"):
+            hook._prepare_cli_cmd()