Skip to content

Commit

Permalink
Make cncf.kubernetes required for flink provider (#29710)
Browse files Browse the repository at this point in the history
The #29707 added version to optional cncf.kubernetes dependency, but
in fact the kubernetes provider is a required dependency so we need
to change it to be so.
  • Loading branch information
potiuk committed Feb 23, 2023
1 parent f038854 commit 68412e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
15 changes: 1 addition & 14 deletions airflow/providers/apache/flink/provider.yaml
Expand Up @@ -27,15 +27,7 @@ versions:
dependencies:
- apache-airflow>=2.3.0
- cryptography>=2.0.0
# The Kubernetes API is known to introduce problems when upgraded to a MAJOR version. Airflow Core
# Uses Kubernetes for Kubernetes executor, and we also know that Kubernetes Python client follows SemVer
# (https://github.com/kubernetes-client/python#compatibility). This is a crucial component of Airflow
# So we should limit it to the next MAJOR version and only deliberately bump the version when we
# tested it, and we know it can be bumped. Bumping this version should also be connected with
# limiting minimum airflow version supported in cncf.kubernetes provider, due to the
# potential breaking changes in Airflow Core as well (kubernetes is added as extra, so Airflow
# core is not hard-limited via install-requirements, only by extra).
- kubernetes>=21.7.0,<24
- apache-airflow-providers-cncf-kubernetes>=5.1.0

integrations:
- integration-name: Apache Flink
Expand All @@ -54,8 +46,3 @@ sensors:
- integration-name: Apache Flink
python-modules:
- airflow.providers.apache.flink.sensors.flink_kubernetes

additional-extras:
- name: cncf.kubernetes
dependencies:
- apache-airflow-providers-cncf-kubernetes>=5.1.0
4 changes: 2 additions & 2 deletions generated/provider_dependencies.json
Expand Up @@ -80,9 +80,9 @@
},
"apache.flink": {
"deps": [
"apache-airflow-providers-cncf-kubernetes>=5.1.0",
"apache-airflow>=2.3.0",
"cryptography>=2.0.0",
"kubernetes>=21.7.0,<24"
"cryptography>=2.0.0"
],
"cross-providers-deps": [
"cncf.kubernetes"
Expand Down

0 comments on commit 68412e1

Please sign in to comment.