Do not calculate grid root instances (#24528)

* do not calculate grid root instances * fix tests
apache · Jun 17, 2022 · 8b054ef · 8b054ef
1 parent 31f113e
commit 8b054ef
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 18 deletions.
diff --git a/airflow/www/views.py b/airflow/www/views.py
@@ -387,6 +387,15 @@ def get_summary(dag_run, children):
                 'end_date': group_end_date,
             }
 
+        # We don't need to calculate summaries for the root
+        if task_group.group_id is None:
+            return {
+                'id': task_group.group_id,
+                'label': task_group.label,
+                'children': children,
+                'instances': [],
+            }
+
         group_summaries = [get_summary(dr, children) for dr in dag_runs]
 
         return {

diff --git a/tests/www/views/test_views_grid.py b/tests/www/views/test_views_grid.py
@@ -116,7 +116,6 @@ def test_no_runs(admin_client, dag_without_runs):
             'id': None,
             'instances': [],
             'label': None,
-            'tooltip': '',
         },
     }
 
@@ -249,24 +248,8 @@ def test_one_run(admin_client, dag_with_runs: List[DagRun], session):
                 },
             ],
             'id': None,
-            'instances': [
-                {
-                    'end_date': None,
-                    'run_id': 'run_1',
-                    'start_date': None,
-                    'state': 'success',
-                    'task_id': None,
-                },
-                {
-                    'end_date': '2021-07-01T01:02:03+00:00',
-                    'run_id': 'run_2',
-                    'start_date': '2021-07-01T01:00:00+00:00',
-                    'state': 'running',
-                    'task_id': None,
-                },
-            ],
+            'instances': [],
             'label': None,
-            'tooltip': '',
         },
     }