Skip to content

Commit

Permalink
E731: replace lambda by a def method in Airflow core (#33758)
Browse files Browse the repository at this point in the history
  • Loading branch information
hussein-awala committed Aug 26, 2023
1 parent e16e9f3 commit a1d4a20
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
5 changes: 4 additions & 1 deletion airflow/cli/cli_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ def add_to_parser(self, parser: argparse.ArgumentParser):
"""Add this argument to an ArgumentParser."""
if "metavar" in self.kwargs and "type" not in self.kwargs:
if self.kwargs["metavar"] == "DIRPATH":
type = lambda x: self._is_valid_directory(parser, x)

def type(x):
return self._is_valid_directory(parser, x)

self.kwargs["type"] = type
parser.add_argument(*self.flags, **self.kwargs)

Expand Down
5 changes: 4 additions & 1 deletion airflow/cli/commands/connection_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,10 @@ def create_default_connections(args):

def _format_connections(conns: list[Connection], file_format: str, serialization_format: str) -> str:
if serialization_format == "json":
serializer_func = lambda x: json.dumps(_connection_to_dict(x))

def serializer_func(x):
return json.dumps(_connection_to_dict(x))

elif serialization_format == "uri":
serializer_func = Connection.get_uri
else:
Expand Down
10 changes: 8 additions & 2 deletions airflow/www/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,15 @@ def dag_to_grid(dag: DagModel, dag_runs: Sequence[DagRun], session: Session):

sort_order = conf.get("webserver", "grid_view_sorting_order", fallback="topological")
if sort_order == "topological":
sort_children_fn = lambda task_group: task_group.topological_sort()

def sort_children_fn(task_group):
return task_group.topological_sort()

elif sort_order == "hierarchical_alphabetical":
sort_children_fn = lambda task_group: task_group.hierarchical_alphabetical_sort()

def sort_children_fn(task_group):
return task_group.hierarchical_alphabetical_sort()

else:
raise AirflowConfigException(f"Unsupported grid_view_sorting_order: {sort_order}")

Expand Down

0 comments on commit a1d4a20

Please sign in to comment.