Skip to content

Commit

Permalink
fix(standalone): Remove hardcoded Webserver port (#20429)
Browse files Browse the repository at this point in the history
Port 8080 is the default port for webserver (https://airflow.apache.org/docs/apache-airflow/stable/cli-and-env-variables-ref.html?highlight=webserver#webserver). By setting it here again explicitly, we forbid users to override it using AIRFLOW__WEBSERVER__WEB_SERVER_PORT. Removing it IMO is not a breaking change, since it will still default to 8080.

(cherry picked from commit 9d36b1f)
  • Loading branch information
boredland authored and jedcunningham committed Jan 20, 2022
1 parent 330c365 commit b19dfdb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion airflow/cli/commands/standalone_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def run(self):
self.subcommands["webserver"] = SubCommand(
self,
name="webserver",
command=["webserver", "--port", "8080"],
command=["webserver"],
env=env,
)
self.subcommands["triggerer"] = SubCommand(
Expand Down
1 change: 1 addition & 0 deletions docs/apache-airflow/start/local.rst
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ constraint files to enable reproducible installation, so using ``pip`` and const
Upon running these commands, Airflow will create the ``$AIRFLOW_HOME`` folder
and create the "airflow.cfg" file with defaults that will get you going fast.
You can override defaults using environment variables, see :doc:`/configurations-ref`.
You can inspect the file either in ``$AIRFLOW_HOME/airflow.cfg``, or through the UI in
the ``Admin->Configuration`` menu. The PID file for the webserver will be stored
in ``$AIRFLOW_HOME/airflow-webserver.pid`` or in ``/run/airflow/webserver.pid``
Expand Down

0 comments on commit b19dfdb

Please sign in to comment.