Simplify code around enumerate (#33476)

apache · Aug 19, 2023 · bcefe61 · bcefe61
1 parent 6d3b71c
commit bcefe61
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/airflow/models/baseoperator.py b/airflow/models/baseoperator.py
@@ -1713,8 +1713,7 @@ def chain(*tasks: DependencyMixin | Sequence[DependencyMixin]) -> None:
 
     :param tasks: Individual and/or list of tasks, EdgeModifiers, XComArgs, or TaskGroups to set dependencies
     """
-    for index, up_task in enumerate(tasks[:-1]):
-        down_task = tasks[index + 1]
+    for up_task, down_task in zip(tasks, tasks[1:]):
         if isinstance(up_task, DependencyMixin):
             up_task.set_downstream(down_task)
             continue

diff --git a/airflow/providers/apache/hive/transfers/mssql_to_hive.py b/airflow/providers/apache/hive/transfers/mssql_to_hive.py
@@ -118,9 +118,8 @@ def execute(self, context: Context):
                 with NamedTemporaryFile(mode="w", encoding="utf-8") as tmp_file:
                     csv_writer = csv.writer(tmp_file, delimiter=self.delimiter)
                     field_dict = OrderedDict()
-                    for col_count, field in enumerate(cursor.description, start=1):
-                        col_position = f"Column{col_count}"
-                        field_dict[col_position if field[0] == "" else field[0]] = self.type_map(field[1])
+                    for col_count, (key, val) in enumerate(cursor.description, start=1):
+                        field_dict[key or f"Column{col_count}"] = self.type_map(val)
                     csv_writer.writerows(cursor)
                     tmp_file.flush()
 

diff --git a/airflow/providers/apache/hive/transfers/vertica_to_hive.py b/airflow/providers/apache/hive/transfers/vertica_to_hive.py
@@ -122,9 +122,8 @@ def execute(self, context: Context):
         with NamedTemporaryFile(mode="w", encoding="utf-8") as f:
             csv_writer = csv.writer(f, delimiter=self.delimiter)
             field_dict = OrderedDict()
-            for col_count, field in enumerate(cursor.description, start=1):
-                col_position = f"Column{col_count}"
-                field_dict[col_position if field[0] == "" else field[0]] = self.type_map(field[1])
+            for col_count, (key, val) in enumerate(cursor.description, start=1):
+                field_dict[key or f"Column{col_count}"] = self.type_map(val)
             csv_writer.writerows(cursor.iterate())
             f.flush()
             cursor.close()